fix: make GoogleAI Chat Generator compatible with new ChatMessage; small fixes to Cohere tests
#1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
changed the title
ChatMessageChatMessage; small fixes to Cohere tests
anakin87
commented
Dec 18, 2024
| @@ -266,10 +271,21 @@ def _message_to_content(self, message: ChatMessage) -> Content: | |||
| part.function_response.response = message.text | |||
| elif message.is_from(ChatRole.USER): | |||
| part = self._convert_part(message.text) | |||
| elif "TOOL" in ChatRole._member_names_ and message.is_from(ChatRole.TOOL): | |||
There was a problem hiding this comment.
(Even if I don't particularly like this check) this is done to check if the message has the tool role - only present in Haystack main (to be released in 2.9.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
ChatMessage#1249: read the issue for detailsProposed Changes:
ChatMessageHow did you test it?
CI; local tests with Haystack main branch
Notes for the reviewer
These changes are temporary. I hope to get rid of them soon, once we reimplement this ChatGenerator to add proper tool support.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.